WillAyd commented on code in PR #683: URL: https://github.com/apache/arrow-nanoarrow/pull/683#discussion_r1850481037
########## src/nanoarrow/common/inline_types.h: ########## @@ -916,13 +922,14 @@ static inline void ArrowDecimalInit(struct ArrowDecimal* decimal, int32_t bitwid memset(decimal->words, 0, sizeof(decimal->words)); decimal->precision = precision; decimal->scale = scale; + // n_words will be 0 for bitwidth == 32 Review Comment: Arrow C++ still operates against 64 bit words with decimals right? Guessing the 32 bit implementation upstream still needs to be worked out? https://github.com/apache/arrow/blob/cd3321b28b0c9703e5d7105d6146c1270bbadd7f/cpp/src/arrow/util/decimal.cc#L527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
