onursatici commented on code in PR #6779:
URL: https://github.com/apache/arrow-rs/pull/6779#discussion_r1855182756
##########
arrow-select/src/interleave.rs:
##########
@@ -231,6 +239,39 @@ fn interleave_dictionaries<K: ArrowDictionaryKeyType>(
Ok(Arc::new(array))
}
+fn interleave_views<T: ByteViewType>(
+ values: &[&dyn Array],
+ indices: &[(usize, usize)],
+) -> Result<ArrayRef, ArrowError> {
+ let interleaved = Interleave::<'_, GenericByteViewArray<T>>::new(values,
indices);
+ let mut views_builder = BufferBuilder::new(indices.len());
+ let mut buffers = Vec::with_capacity(values[0].len());
+
+ let mut buffer_lookup = HashMap::new();
+ for (array_idx, value_idx) in indices {
+ let array = interleaved.arrays[*array_idx];
+ let raw_view = array.views().get(*value_idx).unwrap();
+ let view = ByteView::from(*raw_view);
+
+ if view.length <= 12 {
+ views_builder.append(*raw_view);
+ continue;
+ }
+ // value is big enough to be in a variadic buffer
+ let new_buffer_idx: &mut u32 = buffer_lookup
+ .entry((*array_idx, view.buffer_index))
+ .or_insert_with(|| {
+ buffers.push(array.data_buffers()[view.buffer_index as
usize].clone());
+ (buffers.len() - 1) as u32
+ });
+ views_builder.append(view.with_buffer_index(*new_buffer_idx).into());
+ }
+
+ let array =
+ GenericByteViewArray::<T>::try_new(views_builder.into(), buffers,
interleaved.nulls)?;
Review Comment:
should we do `new_unchecked` here instead similar to other specific
interleave methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
