bkietz commented on a change in pull request #9725:
URL: https://github.com/apache/arrow/pull/9725#discussion_r596092120
##########
File path: cpp/src/arrow/dataset/file_csv.h
##########
@@ -37,6 +37,11 @@ class ARROW_DS_EXPORT CsvFileFormat : public FileFormat {
public:
/// Options affecting the parsing of CSV files
csv::ParseOptions parse_options = csv::ParseOptions::Defaults();
+ /// Options affecting how CSV files are read.
+ ///
+ /// Note use_threads is ignored (it is always considered false) and
block_size
+ /// should be set on CsvFragmentScanOptions.
+ csv::ReadOptions read_options = csv::ReadOptions::Defaults();
Review comment:
I'm not sure it's reasonable to add `ReadOptions` here. I think only
`skip_rows` and `autogenerate_column_names` are meaningful here. Column
renaming can be accomplished in projection if desired (obviating
`column_names`) and as noted `use_threads` and `block_size` are configured
elsewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
