jorisvandenbossche commented on a change in pull request #9725:
URL: https://github.com/apache/arrow/pull/9725#discussion_r596904581
##########
File path: cpp/src/arrow/dataset/scanner.h
##########
@@ -240,6 +240,9 @@ class ARROW_DS_EXPORT ScannerBuilder {
/// \brief Set the pool from which materialized and scanned arrays will be
allocated.
Status Pool(MemoryPool* pool);
+ /// \brief Set fragment-specific scan options.
+ Status FragmentScanOptions(std::shared_ptr<FragmentScanOptions>
fragment_scan_options);
Review comment:
Just ScanOptions instead of FragmentScanOptions might be more
descriptive? (I find the "fragment" in it a bit confusing) Because it's not
that this can be set for each fragment. It's the same for all fragments *for
one scan*.
##########
File path: cpp/src/arrow/dataset/scanner.h
##########
@@ -240,6 +240,9 @@ class ARROW_DS_EXPORT ScannerBuilder {
/// \brief Set the pool from which materialized and scanned arrays will be
allocated.
Status Pool(MemoryPool* pool);
+ /// \brief Set fragment-specific scan options.
+ Status FragmentScanOptions(std::shared_ptr<FragmentScanOptions>
fragment_scan_options);
Review comment:
Ah, but we already have a ScanOptions of course ;)
Then maybe `FormatScanOptions`? Since it are format-specific options?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
