pitrou commented on code in PR #44867:
URL: https://github.com/apache/arrow/pull/44867#discussion_r1861825535
##########
cpp/src/arrow/array/array_dict.h:
##########
@@ -90,7 +90,11 @@ class ARROW_EXPORT DictionaryArray : public Array {
/// \param[in] type the new type object
/// \param[in] dictionary the new dictionary
/// \param[in] transpose_map transposition array of this array's indices
- /// into the target array's indices
+ /// into the target array's indices. The value of transpose_map should
+ /// be in the range [0, this->length()). And the dictionary array's
+ /// indices in the target array's indices should be in the range
+ /// of [0, dictionary->length()).
Review Comment:
Those two sentences are difficult to understand, and I'm not sure they are
correct either. Are you sure you want to add this?
##########
cpp/src/arrow/array/array_dict.cc:
##########
@@ -320,7 +320,7 @@ Result<std::shared_ptr<Array>> DictionaryArray::Transpose(
ARROW_ASSIGN_OR_RAISE(auto transposed,
TransposeDictIndices(data_, data_->type, type,
dictionary->data(),
transpose_map, pool));
- return MakeArray(std::move(transposed));
+ return MakeArray(transposed);
Review Comment:
Why change this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
