pitrou commented on code in PR #44867:
URL: https://github.com/apache/arrow/pull/44867#discussion_r1861843170
##########
cpp/src/arrow/array/array_dict.cc:
##########
@@ -320,7 +320,7 @@ Result<std::shared_ptr<Array>> DictionaryArray::Transpose(
ARROW_ASSIGN_OR_RAISE(auto transposed,
TransposeDictIndices(data_, data_->type, type,
dictionary->data(),
transpose_map, pool));
- return MakeArray(std::move(transposed));
+ return MakeArray(transposed);
Review Comment:
Well, perhaps `MakeArray` will be fixed at some point, but there's no reason
to remove the move here? It's not worse in any case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
