pitrou commented on code in PR #44813:
URL: https://github.com/apache/arrow/pull/44813#discussion_r1862451534
##########
cpp/src/arrow/array/builder_primitive.h:
##########
@@ -443,34 +443,34 @@ class ARROW_EXPORT BooleanBuilder
/// \brief Append a sequence of elements in one shot
/// \param[in] values a contiguous C array of values
/// \param[in] length the number of values to append
- /// \param[in] is_valid an std::vector<bool> indicating valid (1) or null
+ /// \param[in] is_valid a std::vector<bool> indicating valid (1) or null
/// (0). Equal in length to values
/// \return Status
Status AppendValues(const uint8_t* values, int64_t length,
const std::vector<bool>& is_valid);
/// \brief Append a sequence of elements in one shot
- /// \param[in] values a std::vector of bytes
- /// \param[in] is_valid an std::vector<bool> indicating valid (1) or null
+ /// \param[in] values an arrow::util::span of bytes
Review Comment:
Can just say "a span of bytes" IMHO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
