pitrou commented on code in PR #44813: URL: https://github.com/apache/arrow/pull/44813#discussion_r1862451011
########## cpp/src/arrow/array/builder_primitive.cc: ########## @@ -105,12 +105,12 @@ Status BooleanBuilder::AppendValues(const uint8_t* values, int64_t length, return Status::OK(); } -Status BooleanBuilder::AppendValues(const std::vector<uint8_t>& values, +Status BooleanBuilder::AppendValues(const util::span<uint8_t> values, Review Comment: So, `const std::vector<T>&` should be replaced with `util::span<const T>`, not `const util::span<T>` (because a `span`'s constness doesn't propagate to the elements it points to, unlike `vector`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
