malinjawi commented on code in PR #44819:
URL: https://github.com/apache/arrow/pull/44819#discussion_r1862460043
##########
cpp/src/parquet/arrow/schema.h:
##########
@@ -104,7 +104,7 @@ struct PARQUET_EXPORT SchemaField {
/// Expose parquet columns as a tree structure. Useful traverse and link
/// between arrow's Schema and parquet's Schema.
struct PARQUET_EXPORT SchemaManifest {
- static ::arrow::Status Make(
+ static ::arrow::Result<std::unique_ptr<FileReader>> Make(
Review Comment:
Alright, I have reverted this now.
##########
cpp/src/parquet/arrow/writer.h:
##########
@@ -53,10 +53,11 @@ namespace arrow {
/// file.
class PARQUET_EXPORT FileWriter {
public:
- static ::arrow::Status Make(MemoryPool* pool,
std::unique_ptr<ParquetFileWriter> writer,
- std::shared_ptr<::arrow::Schema> schema,
- std::shared_ptr<ArrowWriterProperties>
arrow_properties,
- std::unique_ptr<FileWriter>* out);
+ static ::arrow::Result<std::unique_ptr<FileReader>> Make(
+ MemoryPool* pool, std::unique_ptr<ParquetFileWriter> writer,
+ std::shared_ptr<::arrow::Schema> schema,
+ std::shared_ptr<ArrowWriterProperties> arrow_properties,
+ std::unique_ptr<FileWriter>* out);
Review Comment:
Alright, I have reverted this now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
