malinjawi commented on code in PR #44819:
URL: https://github.com/apache/arrow/pull/44819#discussion_r1862461228


##########
cpp/src/parquet/bloom_filter.cc:
##########
@@ -77,7 +77,7 @@ void BlockSplitBloomFilter::Init(const uint8_t* bitset, 
uint32_t num_bytes) {
 
 static constexpr uint32_t kBloomFilterHeaderSizeGuess = 256;
 
-static ::arrow::Status ValidateBloomFilterHeader(
+static ::arrow::Result<std::unique_ptr<FileReader>> ValidateBloomFilterHeader(

Review Comment:
   Reverted. @kou Also, would be beneficial to have an issue with subtasks for 
this refactoring? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to