lidavidm commented on a change in pull request #9728:
URL: https://github.com/apache/arrow/pull/9728#discussion_r596819576
##########
File path: cpp/src/arrow/flight/client.h
##########
@@ -94,8 +94,6 @@ class ARROW_FLIGHT_EXPORT FlightWriteSizeStatusDetail :
public arrow::StatusDeta
class ARROW_FLIGHT_EXPORT FlightClientOptions {
public:
- FlightClientOptions();
Review comment:
Ok, since this is a footgun, I've changed these options to behave like
the IPC options: while there's a Defaults(), the default values are all set as
default field values and the default constructor is left as-is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]