cyb70289 commented on a change in pull request #9728:
URL: https://github.com/apache/arrow/pull/9728#discussion_r598397716
##########
File path: cpp/src/arrow/flight/client.cc
##########
@@ -90,9 +90,6 @@ std::shared_ptr<FlightWriteSizeStatusDetail>
FlightWriteSizeStatusDetail::Unwrap
return
std::dynamic_pointer_cast<FlightWriteSizeStatusDetail>(status.detail());
}
-FlightClientOptions::FlightClientOptions()
- : write_size_limit_bytes(0), disable_server_verification(false) {}
-
FlightClientOptions FlightClientOptions::Defaults() { return
FlightClientOptions(); }
Review comment:
Hmm... a bit lost about where the the fields are explicitly initialized.
Do you mean depends on struct zero initialization, as the two fields happen
to be zero?
I don't see initial values in FlightClientOptions declaration
https://github.com/apache/arrow/blob/master/cpp/src/arrow/flight/client.h#L116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
