andygrove commented on PR #6836: URL: https://github.com/apache/arrow-rs/pull/6836#issuecomment-2518570636
> Have we run any benchmarks (I'm not sure if any actually exist) to confirm this doesn't significantly regress performance. > > It seems unfortunate to be always performing overflow checks, when in many cases it should be possible to prove that precision overflow can't occur and need not be checked for I'll create a separate PR (probably tomorrow) to add some criterion benchmarks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
