himadripal commented on code in PR #6836:
URL: https://github.com/apache/arrow-rs/pull/6836#discussion_r1870615156
##########
arrow-cast/src/cast/decimal.rs:
##########
@@ -155,28 +163,24 @@ where
T: DecimalType,
T::Native: DecimalCast + ArrowNativeTypeOp,
{
- let array: PrimitiveArray<T> = match input_scale.cmp(&output_scale) {
- Ordering::Equal => {
- // the scale doesn't change, the native value don't need to be
changed
- array.clone()
- }
- Ordering::Greater => convert_to_smaller_scale_decimal::<T, T>(
- array,
- input_scale,
- output_precision,
- output_scale,
- cast_options,
- )?,
- Ordering::Less => {
- // input_scale < output_scale
+ let array: PrimitiveArray<T> = if input_scale <= output_scale {
+ // input_scale <= output_scale
+ // the scale doesn't change, but precision may change and cause
overflow
Review Comment:
won't it still has to go through the
`convert_to_bigger_or_equal_scale_decimal` to add the zero at the end for
bigger precision conversion. IMO, we can only skip the call if precision is
less and scales are equal. Please correct me here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
