andygrove commented on code in PR #6853:
URL: https://github.com/apache/arrow-rs/pull/6853#discussion_r1874172624
##########
arrow-schema/src/ffi.rs:
##########
@@ -685,66 +686,68 @@ impl TryFrom<&DataType> for FFI_ArrowSchema {
}
}
-fn get_format_string(dtype: &DataType) -> Result<String, ArrowError> {
+fn get_format_string(dtype: &DataType) -> Result<Cow<'static, str>,
ArrowError> {
Review Comment:
Are you saying we can use `&str` return instead of `Cow`? some of the data
types use `format!` to create new strings so I don't think that can work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
