alamb commented on code in PR #6853:
URL: https://github.com/apache/arrow-rs/pull/6853#discussion_r1874409282
##########
arrow-schema/src/ffi.rs:
##########
@@ -685,66 +686,68 @@ impl TryFrom<&DataType> for FFI_ArrowSchema {
}
}
-fn get_format_string(dtype: &DataType) -> Result<String, ArrowError> {
+fn get_format_string(dtype: &DataType) -> Result<Cow<'static, str>,
ArrowError> {
Review Comment:
strictly speaking this is an API change, but since the next scheduled
release is a major one (allows API changes) we can merge it in to main without
worry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
