alamb commented on code in PR #6804:
URL: https://github.com/apache/arrow-rs/pull/6804#discussion_r1877959841
##########
arrow-flight/Cargo.toml:
##########
@@ -43,11 +43,11 @@ base64 = { version = "0.22", default-features = false,
features = ["std"] }
bytes = { version = "1", default-features = false }
futures = { version = "0.3", default-features = false, features = ["alloc"] }
once_cell = { version = "1", optional = true }
-paste = { version = "1.0" }
+paste = { version = "1.0" , optional = true }
prost = { version = "0.13.1", default-features = false, features =
["prost-derive"] }
# For Timestamp type
prost-types = { version = "0.13.1", default-features = false }
-tokio = { version = "1.0", default-features = false, features = ["macros",
"rt", "rt-multi-thread"] }
+tokio = { version = "1.0", default-features = false, features = ["macros",
"rt", "rt-multi-thread"], optional = true }
Review Comment:
💯
##########
.github/workflows/arrow.yml:
##########
@@ -164,36 +164,138 @@ jobs:
- name: Setup Clippy
run: rustup component add clippy
- name: Clippy arrow-buffer with all features
- run: cargo clippy -p arrow-buffer --all-targets --all-features -- -D
warnings
+ run: |
+ mod=arrow-buffer
+ cargo clippy -p "$mod" --all-targets --all-features -- -D warnings
+ # Dependency checks excluding tests & benches.
+ cargo clippy -p "$mod" -- -D unused_crate_dependencies
+ cargo clippy -p "$mod" --all-features -- -D unused_crate_dependencies
+ cargo clippy -p "$mod" --no-default-features -- -D
unused_crate_dependencies
- name: Clippy arrow-data with all features
- run: cargo clippy -p arrow-data --all-targets --all-features -- -D
warnings
- - name: Clippy arrow-schema with all features
- run: cargo clippy -p arrow-schema --all-targets --all-features -- -D
warnings
- - name: Clippy arrow-array with all features
- run: cargo clippy -p arrow-array --all-targets --all-features -- -D
warnings
+ run: |
+ mod=arrow-data
+ cargo clippy -p "$mod" --all-targets --all-features -- -D warnings
+ # Dependency checks excluding tests & benches.
+ cargo clippy -p "$mod" -- -D unused_crate_dependencies
+ cargo clippy -p "$mod" --all-features -- -D unused_crate_dependencies
+ cargo clippy -p "$mod" --no-default-features -- -D
unused_crate_dependencies
+ - name: Clippy arrow-schema
Review Comment:
Nit- the names are slightly inconsistent:
```suggestion
- name: Clippy arrow-schema with all features
```
##########
.github/workflows/arrow.yml:
##########
@@ -164,36 +164,138 @@ jobs:
- name: Setup Clippy
run: rustup component add clippy
- name: Clippy arrow-buffer with all features
- run: cargo clippy -p arrow-buffer --all-targets --all-features -- -D
warnings
+ run: |
+ mod=arrow-buffer
+ cargo clippy -p "$mod" --all-targets --all-features -- -D warnings
+ # Dependency checks excluding tests & benches.
+ cargo clippy -p "$mod" -- -D unused_crate_dependencies
+ cargo clippy -p "$mod" --all-features -- -D unused_crate_dependencies
+ cargo clippy -p "$mod" --no-default-features -- -D
unused_crate_dependencies
- name: Clippy arrow-data with all features
- run: cargo clippy -p arrow-data --all-targets --all-features -- -D
warnings
- - name: Clippy arrow-schema with all features
- run: cargo clippy -p arrow-schema --all-targets --all-features -- -D
warnings
- - name: Clippy arrow-array with all features
- run: cargo clippy -p arrow-array --all-targets --all-features -- -D
warnings
+ run: |
+ mod=arrow-data
+ cargo clippy -p "$mod" --all-targets --all-features -- -D warnings
+ # Dependency checks excluding tests & benches.
+ cargo clippy -p "$mod" -- -D unused_crate_dependencies
+ cargo clippy -p "$mod" --all-features -- -D unused_crate_dependencies
+ cargo clippy -p "$mod" --no-default-features -- -D
unused_crate_dependencies
+ - name: Clippy arrow-schema
+ run: |
+ mod=arrow-schema
+ cargo clippy -p "$mod" --all-targets --all-features -- -D warnings
+ # Dependency checks excluding tests & benches.
+ cargo clippy -p "$mod" -- -D unused_crate_dependencies
+ cargo clippy -p "$mod" --all-features -- -D unused_crate_dependencies
+ cargo clippy -p "$mod" --no-default-features -- -D
unused_crate_dependencies
+ - name: Clippy arrow-array
Review Comment:
```suggestion
- name: Clippy arrow-array with all features
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
