findepi commented on code in PR #6804:
URL: https://github.com/apache/arrow-rs/pull/6804#discussion_r1879718116
##########
.github/workflows/arrow.yml:
##########
@@ -164,36 +164,138 @@ jobs:
- name: Setup Clippy
run: rustup component add clippy
- name: Clippy arrow-buffer with all features
- run: cargo clippy -p arrow-buffer --all-targets --all-features -- -D
warnings
+ run: |
+ mod=arrow-buffer
+ cargo clippy -p "$mod" --all-targets --all-features -- -D warnings
+ # Dependency checks excluding tests & benches.
+ cargo clippy -p "$mod" -- -D unused_crate_dependencies
+ cargo clippy -p "$mod" --all-features -- -D unused_crate_dependencies
+ cargo clippy -p "$mod" --no-default-features -- -D
unused_crate_dependencies
- name: Clippy arrow-data with all features
- run: cargo clippy -p arrow-data --all-targets --all-features -- -D
warnings
- - name: Clippy arrow-schema with all features
- run: cargo clippy -p arrow-schema --all-targets --all-features -- -D
warnings
- - name: Clippy arrow-array with all features
- run: cargo clippy -p arrow-array --all-targets --all-features -- -D
warnings
+ run: |
+ mod=arrow-data
+ cargo clippy -p "$mod" --all-targets --all-features -- -D warnings
+ # Dependency checks excluding tests & benches.
+ cargo clippy -p "$mod" -- -D unused_crate_dependencies
+ cargo clippy -p "$mod" --all-features -- -D unused_crate_dependencies
+ cargo clippy -p "$mod" --no-default-features -- -D
unused_crate_dependencies
+ - name: Clippy arrow-schema
Review Comment:
I'd go opposite direction, ie remove "with all features" as now this tests
various combinations: "all features", "default features", "no features"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
