adamreeve commented on code in PR #44990:
URL: https://github.com/apache/arrow/pull/44990#discussion_r1879225944
##########
cpp/src/parquet/encryption/internal_file_decryptor.cc:
##########
@@ -64,16 +64,6 @@
InternalFileDecryptor::InternalFileDecryptor(FileDecryptionProperties* propertie
properties_->set_utilized();
}
-void InternalFileDecryptor::WipeOutDecryptionKeys() {
- std::lock_guard<std::mutex> lock(mutex_);
- properties_->WipeOutDecryptionKeys();
- for (auto const& i : all_decryptors_) {
Review Comment:
I think being able to wipe out the decryptors is the only reason the
`all_decryptors_` and `mutex_` members exist, so those should be able to be
removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
