EnricoMi commented on code in PR #44990:
URL: https://github.com/apache/arrow/pull/44990#discussion_r1880772102
##########
cpp/src/arrow/dataset/file_parquet.cc:
##########
@@ -544,7 +545,7 @@ Future<std::shared_ptr<parquet::arrow::FileReader>>
ParquetFileFormat::GetReader
// here we know there are no other waiters on the reader.
std::move(const_cast<std::unique_ptr<parquet::ParquetFileReader>&>(
reader)),
- std::move(arrow_properties), &arrow_reader));
+ arrow_properties, &arrow_reader));
Review Comment:
Argument `const ArrowReaderProperties& properties` is passed as a const
reference, so no move will happen:
Clang-Tidy: Passing result of std::move() as a const reference argument;
no move will actually happen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
