nealrichardson commented on PR #44989:
URL: https://github.com/apache/arrow/pull/44989#issuecomment-2536096463

   It's possible the version comparison error is from this: 
https://github.com/apache/arrow/pull/44989/files#diff-935746c34b16289a07b0d9bf7642dbd268b18059b6187f7cdec7c464be47a3deL731-L743
   
   ```
   cmake_version <- function(cmd = "cmake") {
     tryCatch(
       {
         raw_version <- system(paste(cmd, "--version"), intern = TRUE, 
ignore.stderr = TRUE)
         pat <- ".* ([0-9\\.]+).*?"
         which_line <- grep(pat, raw_version)
         package_version(sub(pat, "\\1", raw_version[which_line]))
       },
       error = function(e) {
         return(0)
       }
     )
   }
   ```
   
   The error case should probably `return("0")`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to