jonkeane commented on code in PR #44989: URL: https://github.com/apache/arrow/pull/44989#discussion_r1882407627
########## .env: ########## @@ -54,6 +54,7 @@ UBUNTU=22.04 # Default versions for various dependencies CLANG_TOOLS=14 +CMAKE=3.25.0 Review Comment: Would it be possible (and also would it be advisable...) to call this `CMAKE_VERSION` instead? One of the R failures I suspect might be due to us looking to `CMAKE` for a path to the cmake executable itself at https://github.com/apache/arrow/blob/bcb5bd30d0452a95ed7c44fc3bd6c8e3f67faab1/r/tools/nixlibs.R#L695 (though I don't have a full traceback I'm not 100% certain on that) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
