Tom-Newton commented on code in PR #45021:
URL: https://github.com/apache/arrow/pull/45021#discussion_r1885011931
##########
cpp/src/arrow/filesystem/azurefs.cc:
##########
@@ -148,8 +148,10 @@ Status AzureOptions::ExtractFromUriQuery(const Uri& uri) {
ARROW_ASSIGN_OR_RAISE(background_writes,
::arrow::internal::ParseBoolean(kv.second));
} else {
- return Status::Invalid(
- "Unexpected query parameter in Azure Blob File System URI: '",
kv.first, "'");
+ // Assume these are part of a SAS token. Its not ideal to make such an
assumption
+ // but given that a SAS token is a complex set of URI parameters, that
could be
+ // tricky to exhaustively list I think its the best option.
+ credential_kind = CredentialKind::kSasToken;
Review Comment:
Yeah, I had a quick search and couldn't find what we need. If you think it's
important I can try a bit harder. The closest I found seemed to be
unabbreviated versions of what actually appears in the sas token.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
