Tom-Newton commented on code in PR #45021:
URL: https://github.com/apache/arrow/pull/45021#discussion_r1888348936
##########
cpp/src/arrow/filesystem/azurefs.cc:
##########
@@ -147,6 +159,10 @@ Status AzureOptions::ExtractFromUriQuery(const Uri& uri) {
} else if (kv.first == "background_writes") {
ARROW_ASSIGN_OR_RAISE(background_writes,
::arrow::internal::ParseBoolean(kv.second));
+ } else if (std::find(sas_token_query_parameters.begin(),
Review Comment:
Could do but I would be a bit concerned about keeping
`sas_token_query_parameters` sorted. It looks like C++20 allows using
`std::sort` with `constexpr` but I believe arrow currently uses C++17. If you
are concerned about the complexity of the lookup I think my preference would be
to use a `std::set` and forget about trying to make it a `constexpr`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
