paleolimbot commented on code in PR #693:
URL: https://github.com/apache/arrow-nanoarrow/pull/693#discussion_r1897646211
##########
src/nanoarrow/ipc/decoder_test.cc:
##########
@@ -508,7 +595,7 @@ TEST_P(ArrowTypeParameterizedTestFixture,
NanoarrowIpcArrowTypeRoundtrip) {
#endif
std::string ArrowSchemaMetadataToString(const char* metadata) {
- struct ArrowMetadataReader reader {};
+ struct ArrowMetadataReader reader;
Review Comment:
It's pretty good about this kind of thing (where the initialization happens
in a function whose body it doesn't have access to). The problem I'm working
around here and should fix properly (by pinning the version in the pre-commit)
is that `clang-format` on homebrew (me!) is very recent but `clang-format` on
ubuntu-latest (CI) is very old, and the formatting of `struct XXXX {};` differs
between them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
