WillAyd commented on code in PR #693:
URL: https://github.com/apache/arrow-nanoarrow/pull/693#discussion_r1896108986
##########
python/pyproject.toml:
##########
@@ -45,6 +45,11 @@ requires = [
build-backend = "mesonpy"
[tool.meson-python.args]
+# Consistent version for zstd, rather than attempting to delocate whatever
+# version was on the build host.
+# TODO: We need to override this somehow on conda-forge because we actually
+# do want the host fallback.
+setup = ['--force-fallback-for=zstd']
Review Comment:
Giving this another review I think you should actually move this to the
`meson.build` configuration on L28, right below the setting we have for
`default_library=static`; that way, all of the configuration is contained in
one place, rather than split between pyproject.toml and the meson config
##########
src/nanoarrow/ipc/decoder_test.cc:
##########
@@ -508,7 +595,7 @@ TEST_P(ArrowTypeParameterizedTestFixture,
NanoarrowIpcArrowTypeRoundtrip) {
#endif
std::string ArrowSchemaMetadataToString(const char* metadata) {
- struct ArrowMetadataReader reader {};
+ struct ArrowMetadataReader reader;
Review Comment:
Not saying this is right or wrong, but I was under the impression clang-tidy
would complain about use of an uninitialized variable here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
