wiedld commented on code in PR #6927:
URL: https://github.com/apache/arrow-rs/pull/6927#discussion_r1900221288
##########
arrow-array/src/builder/generic_bytes_view_builder.rs:
##########
@@ -272,6 +272,56 @@ impl<T: ByteViewType + ?Sized> GenericByteViewBuilder<T> {
}
}
+ /// Builds the [`GenericByteViewArray`] and reset this builder
+ pub fn finish(&mut self) -> GenericByteViewArray<T> {
Review Comment:
Github diff is weird.
These few functions were not changed -- only moved as the `ValuesBuilder`
was implemented below.
##########
arrow-array/src/builder/generic_bytes_view_builder.rs:
##########
@@ -272,6 +272,56 @@ impl<T: ByteViewType + ?Sized> GenericByteViewBuilder<T> {
}
}
+ /// Builds the [`GenericByteViewArray`] and reset this builder
+ pub fn finish(&mut self) -> GenericByteViewArray<T> {
Review Comment:
Github diff is weird. These few functions were not changed -- only moved as
the `ValuesBuilder` was implemented below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
