wiedld commented on code in PR #6927:
URL: https://github.com/apache/arrow-rs/pull/6927#discussion_r1900223247
##########
arrow-string/src/regexp.rs:
##########
@@ -245,71 +247,75 @@ where
Ok(BooleanArray::from(data))
}
-macro_rules! process_regexp_array_match {
- ($array:expr, $regex_array:expr, $flags_array:expr, $list_builder:expr) =>
{
- let mut patterns: HashMap<String, Regex> = HashMap::new();
+fn process_regexp_array_match<
+ 'a,
+ T: ?Sized,
+ A: ArrayAccessor<Item = &'a str>,
+ O: OffsetSizeTrait,
+ B: ValuesBuilder<T, Value = str>,
+>(
+ array: ArrayIter<A>,
+ regex_array: ArrayIter<A>,
+ flags_array: Option<ArrayIter<A>>,
+ list_builder: &mut GenericListBuilder<O, B>,
+) -> Result<(), ArrowError> {
Review Comment:
Logic for this method (previous macro) is the same. It's only the generics
which changed, such as providing generic `ArrayIter` is place of arrays which
then were then converted into an ArrayIter with `array.iter()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
