alamb commented on code in PR #6930:
URL: https://github.com/apache/arrow-rs/pull/6930#discussion_r1903093809
##########
arrow-buffer/src/buffer/immutable.rs:
##########
@@ -79,6 +79,21 @@ impl Buffer {
}
}
+ /// Auxiliary method to create a new Buffer
+ ///
+ /// This is convenient for converting a [`bytes::Bytes`] to a [`Buffer`]
without copying.
Review Comment:
I would like to recommend a `From` implementation in addition to the
explicit function
My rationale is that Rust experts are likely to find the `From`
implementation, but for beginners/intermediate, having an explicit method is
easier to find
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
