tustvold commented on code in PR #6930:
URL: https://github.com/apache/arrow-rs/pull/6930#discussion_r1903094459
##########
arrow-buffer/src/buffer/immutable.rs:
##########
@@ -79,6 +79,21 @@ impl Buffer {
}
}
+ /// Auxiliary method to create a new Buffer
+ ///
+ /// This is convenient for converting a [`bytes::Bytes`] to a [`Buffer`]
without copying.
Review Comment:
I think the name is very confusing, as it isn't clear what external means.
This confusion is not helped by the fact arrow has a Bytes type that isn't
currently public but the from_bytes method is.
Just adding a From implementation is a way to decouple this PR from cleaning
this mess up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
