alamb commented on code in PR #6935:
URL: https://github.com/apache/arrow-rs/pull/6935#discussion_r1903095433
##########
arrow-cast/src/cast/mod.rs:
##########
@@ -9988,8 +9986,7 @@ mod tests {
#[test]
fn test_decimal_to_decimal_throw_error_on_precision_overflow_lower_scale()
{
let array = vec![Some(123456789)];
- let array = create_decimal_array(array, 24, 2).unwrap();
- println!("{:?}", array);
+ let array = create_decimal_array(array, 24, 4).unwrap();
Review Comment:
Can you explain why this is fixing the test? It seems like it changes the
size of the input decimal from (24,2) to (24,4).
This seems fine to me, but also not obvious to me why we are changing the
test
If the idea is to cover a different code path, perhaps we should leave the
existing coverage for (24,2) and add a new test for (24,4) 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
