himadripal commented on code in PR #6935:
URL: https://github.com/apache/arrow-rs/pull/6935#discussion_r1903131554
##########
arrow-cast/src/cast/mod.rs:
##########
@@ -9988,8 +9986,7 @@ mod tests {
#[test]
fn test_decimal_to_decimal_throw_error_on_precision_overflow_lower_scale()
{
let array = vec![Some(123456789)];
- let array = create_decimal_array(array, 24, 2).unwrap();
- println!("{:?}", array);
+ let array = create_decimal_array(array, 24, 4).unwrap();
Review Comment:
Thank you for the review @alamb
Here I'm testing different conversions, In the previous PR, I added 4 tests -
- `test_decimal_to_decimal_throw_error_on_precision_overflow_same_scale`
is to test conversion overflow from (24,2) to (6,2)
-` test_decimal_to_decimal_throw_error_on_precision_overflow_lower_scale` -
this is the current changes, it was supposed to conversion overflow from (24,4)
to (6,2) but input I was creating was creating a decimal array of (24,2). Hence
changed the input decimal array to be of type (24,4)
- `test_decimal_to_decimal_throw_error_on_precision_overflow_greater_scale`
- this one tests (24,2) to (6,3).
- `test_decimal_to_decimal_throw_error_on_precision_overflow_diff_type` this
one between different type Decimal128 to Decimal256.
This PR fixes the second tests input creation, hope this clarifies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
