WillAyd commented on code in PR #702:
URL: https://github.com/apache/arrow-nanoarrow/pull/702#discussion_r1905808029


##########
src/nanoarrow/hpp/view.hpp:
##########
@@ -157,6 +158,7 @@ class ViewArrayAs {
                 array_view->buffer_views[1].data.data,
                 array_view->offset,
             },
+            array_view->offset,

Review Comment:
   This is an easy fix but maybe not the API we want, since we are providing 
the offset to both the Range and the `Get` class template (?)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to