WillAyd commented on code in PR #702:
URL: https://github.com/apache/arrow-nanoarrow/pull/702#discussion_r1905921575
##########
src/nanoarrow/hpp/view.hpp:
##########
@@ -79,7 +80,7 @@ struct RandomAccessRange {
};
const_iterator begin() const { return {0, this}; }
- const_iterator end() const { return {size, this}; }
+ const_iterator end() const { return {size - offset, this}; }
Review Comment:
Not quite what you asked for but I think I've simplified this a bit by
taking the offset out of the `Get` class and making it so that the range bounds
start at the offset and end at `size`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
