lidavidm commented on code in PR #223: URL: https://github.com/apache/arrow-go/pull/223#discussion_r1908130718
########## parquet/metadata/page_index.go: ########## @@ -0,0 +1,889 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package metadata + +import ( + "fmt" + "io" + "math" + + "github.com/JohnCGriffin/overflow" + "github.com/apache/arrow-go/v18/arrow" + "github.com/apache/arrow-go/v18/parquet" + "github.com/apache/arrow-go/v18/parquet/internal/debug" + "github.com/apache/arrow-go/v18/parquet/internal/encoding" + "github.com/apache/arrow-go/v18/parquet/internal/encryption" + format "github.com/apache/arrow-go/v18/parquet/internal/gen-go/parquet" + "github.com/apache/arrow-go/v18/parquet/internal/thrift" + "github.com/apache/arrow-go/v18/parquet/internal/utils" + "github.com/apache/arrow-go/v18/parquet/schema" +) + +type BoundaryOrder = format.BoundaryOrder + +const ( + Unordered BoundaryOrder = format.BoundaryOrder_UNORDERED + Ascending BoundaryOrder = format.BoundaryOrder_ASCENDING + Descending BoundaryOrder = format.BoundaryOrder_DESCENDING +) + +type ColumnIndex interface { Review Comment: It might be useful to have docstrings for public types at least? ########## parquet/file/page_reader.go: ########## @@ -144,6 +161,13 @@ func NewDataPageV1WithStats(buffer *memory.Buffer, num int32, encoding, defEncod return ret } +// NewDataPageV1WithExtras is like WithStats but adds the first row index and size statistics +func NewDataPageV1WithExtras(buffer *memory.Buffer, num int32, encoding, defEncoding, repEncoding parquet.Encoding, uncompressedSize int32, stats metadata.EncodedStatistics, firstRowIdx int64, szStats SizeStatistics) *DataPageV1 { Review Comment: Is it worth putting some of these parameters in a struct so they can be extended in the future? Or is this very likely to be the "last" extension? (Since now we have NewV1, NewV1WithStats, and NewV1WithExtras) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
