zeroshade commented on code in PR #223:
URL: https://github.com/apache/arrow-go/pull/223#discussion_r1909095230
##########
parquet/file/page_reader.go:
##########
@@ -144,6 +161,13 @@ func NewDataPageV1WithStats(buffer *memory.Buffer, num
int32, encoding, defEncod
return ret
}
+// NewDataPageV1WithExtras is like WithStats but adds the first row index and
size statistics
+func NewDataPageV1WithExtras(buffer *memory.Buffer, num int32, encoding,
defEncoding, repEncoding parquet.Encoding, uncompressedSize int32, stats
metadata.EncodedStatistics, firstRowIdx int64, szStats SizeStatistics)
*DataPageV1 {
Review Comment:
I was definitely considering this. Primarily the reason why I keep extending
it like this was to avoid a breaking change (by creating a new func instead of
modifying the hold one) but this is a good point, it would be better to shove a
bunch of these parameters into a struct instead, i'll do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
