zanmato1984 commented on code in PR #45210:
URL: https://github.com/apache/arrow/pull/45210#discussion_r1909297730
##########
cpp/CMakePresets.json:
##########
@@ -46,34 +70,6 @@
"CMAKE_BUILD_TYPE": "RelWithDebInfo"
}
},
- {
Review Comment:
Adjusting order.
##########
cpp/CMakePresets.json:
##########
@@ -174,15 +169,11 @@
{
"name": "features-python",
"inherits": [
- "features-main"
+ "features-main",
+ "features-python-minimal"
Review Comment:
Inheriting to avoid duplicating variables.
##########
cpp/CMakePresets.json:
##########
@@ -371,45 +381,97 @@
"cacheVariables": {}
},
{
- "name": "ninja-debug-valgrind-basic",
+ "name": "ninja-debug-emscripten",
"inherits": [
"base-debug",
- "features-basic",
- "features-valgrind"
+ "features-emscripten"
],
- "displayName": "Debug build for Valgrind with reduced dependencies",
+ "displayName": "Debug build which builds an Emscripten library",
"cacheVariables": {}
},
{
- "name": "ninja-debug-valgrind",
+ "name": "ninja-debug-valgrind-minimal",
"inherits": [
- "base-debug",
- "features-main",
- "features-valgrind"
+ "features-valgrind",
+ "ninja-debug-minimal"
],
- "displayName": "Debug build for Valgrind with more optional components",
+ "displayName": "Debug build for Valgrind without anything enabled",
"cacheVariables": {}
},
{
- "name": "ninja-debug-valgrind-minimal",
+ "name": "ninja-debug-valgrind-basic",
"inherits": [
- "base-debug",
- "features-minimal",
- "features-valgrind"
+ "features-valgrind",
+ "ninja-debug-basic"
],
- "displayName": "Debug build for Valgrind without anything enabled",
+ "displayName": "Debug build for Valgrind with tests and reduced
dependencies",
+ "cacheVariables": {}
+ },
+ {
+ "name": "ninja-debug-valgrind",
+ "inherits": [
+ "features-valgrind",
+ "ninja-debug"
+ ],
+ "displayName": "Debug build for Valgrind with tests and more optional
components",
"cacheVariables": {}
},
{
"name": "ninja-debug-valgrind-maximal",
Review Comment:
Adjusting order to minimal -> basic -> main (omitted) -> maximal.
Also inheriting `ninja-debug-xxx` to replace `base-debug` + `features-xxx`.
##########
cpp/CMakePresets.json:
##########
@@ -371,45 +381,97 @@
"cacheVariables": {}
},
{
- "name": "ninja-debug-valgrind-basic",
+ "name": "ninja-debug-emscripten",
"inherits": [
"base-debug",
- "features-basic",
- "features-valgrind"
+ "features-emscripten"
],
- "displayName": "Debug build for Valgrind with reduced dependencies",
+ "displayName": "Debug build which builds an Emscripten library",
"cacheVariables": {}
},
{
- "name": "ninja-debug-valgrind",
+ "name": "ninja-debug-valgrind-minimal",
"inherits": [
- "base-debug",
- "features-main",
- "features-valgrind"
+ "features-valgrind",
+ "ninja-debug-minimal"
],
- "displayName": "Debug build for Valgrind with more optional components",
+ "displayName": "Debug build for Valgrind without anything enabled",
"cacheVariables": {}
},
{
- "name": "ninja-debug-valgrind-minimal",
+ "name": "ninja-debug-valgrind-basic",
"inherits": [
- "base-debug",
- "features-minimal",
- "features-valgrind"
+ "features-valgrind",
+ "ninja-debug-basic"
],
- "displayName": "Debug build for Valgrind without anything enabled",
+ "displayName": "Debug build for Valgrind with tests and reduced
dependencies",
+ "cacheVariables": {}
+ },
+ {
+ "name": "ninja-debug-valgrind",
+ "inherits": [
+ "features-valgrind",
+ "ninja-debug"
+ ],
+ "displayName": "Debug build for Valgrind with tests and more optional
components",
"cacheVariables": {}
},
{
"name": "ninja-debug-valgrind-maximal",
"inherits": [
- "base-debug",
- "features-maximal",
- "features-valgrind"
+ "features-valgrind",
+ "ninja-debug-maximal"
+ ],
+ "displayName": "Debug build for Valgrind with tests and everything
enabled",
+ "cacheVariables": {}
+ },
+ {
+ "name": "ninja-debug-asan",
+ "inherits": [
+ "_allocator-none",
+ "ninja-debug",
+ "sanitizer-asan"
+ ],
+ "displayName": "Debug build for ASAN with tests and more optional
components",
+ "cacheVariables": {}
+ },
+ {
+ "name": "ninja-debug-tsan",
+ "inherits": [
+ "_allocator-none",
+ "ninja-debug",
+ "sanitizer-tsan"
+ ],
+ "displayName": "Debug build for TSAN with tests and more optional
components",
+ "cacheVariables": {}
+ },
+ {
+ "name": "ninja-debug-ubsan",
+ "inherits": [
+ "_allocator-none",
+ "ninja-debug",
+ "sanitizer-ubsan"
],
- "displayName": "Debug build for Valgrind with everything enabled",
+ "displayName": "Debug build for UBSAN with tests and more optional
components",
"cacheVariables": {}
},
+ {
Review Comment:
Moved from the bottom of the file to after `sanitizer` group because it also
belongs to `debug` group.
##########
cpp/CMakePresets.json:
##########
@@ -103,7 +99,6 @@
"cacheVariables": {
"ARROW_SUBSTRAIT": "ON",
"ARROW_ACERO": "ON",
- "ARROW_MIMALLOC": "ON",
Review Comment:
Removing duplication.
##########
cpp/CMakePresets.json:
##########
@@ -193,35 +184,54 @@
"features-filesystems",
"features-flight-sql",
"features-gandiva",
- "features-main",
- "features-python-minimal"
+ "features-python"
],
"hidden": true,
"cacheVariables": {
- "ARROW_ORC": "ON",
Review Comment:
Reduce duplication.
##########
cpp/CMakePresets.json:
##########
@@ -446,24 +508,6 @@
"displayName": "Release build with CUDA integration",
"cacheVariables": {}
},
- {
- "name": "ninja-debug-emscripten",
- "inherits": [
- "features-emscripten",
- "base-debug"
- ],
- "displayName": "Debug build which builds an Emscripten library",
- "cacheVariables": {}
- },
- {
- "name": "ninja-release-emscripten",
- "inherits": [
- "features-emscripten",
- "base-release"
- ],
- "displayName": "Release build which builds an Emscripten library",
- "cacheVariables": {}
- },
Review Comment:
Moved to after couple of "common" features within release group.
##########
cpp/CMakePresets.json:
##########
@@ -371,45 +381,97 @@
"cacheVariables": {}
},
{
- "name": "ninja-debug-valgrind-basic",
+ "name": "ninja-debug-emscripten",
"inherits": [
"base-debug",
- "features-basic",
- "features-valgrind"
+ "features-emscripten"
],
- "displayName": "Debug build for Valgrind with reduced dependencies",
+ "displayName": "Debug build which builds an Emscripten library",
"cacheVariables": {}
},
{
- "name": "ninja-debug-valgrind",
+ "name": "ninja-debug-valgrind-minimal",
"inherits": [
- "base-debug",
- "features-main",
- "features-valgrind"
+ "features-valgrind",
+ "ninja-debug-minimal"
],
- "displayName": "Debug build for Valgrind with more optional components",
+ "displayName": "Debug build for Valgrind without anything enabled",
"cacheVariables": {}
},
{
- "name": "ninja-debug-valgrind-minimal",
+ "name": "ninja-debug-valgrind-basic",
"inherits": [
- "base-debug",
- "features-minimal",
- "features-valgrind"
+ "features-valgrind",
+ "ninja-debug-basic"
],
- "displayName": "Debug build for Valgrind without anything enabled",
+ "displayName": "Debug build for Valgrind with tests and reduced
dependencies",
+ "cacheVariables": {}
+ },
+ {
+ "name": "ninja-debug-valgrind",
+ "inherits": [
+ "features-valgrind",
+ "ninja-debug"
+ ],
+ "displayName": "Debug build for Valgrind with tests and more optional
components",
"cacheVariables": {}
},
{
"name": "ninja-debug-valgrind-maximal",
"inherits": [
- "base-debug",
- "features-maximal",
- "features-valgrind"
+ "features-valgrind",
+ "ninja-debug-maximal"
+ ],
+ "displayName": "Debug build for Valgrind with tests and everything
enabled",
+ "cacheVariables": {}
+ },
+ {
Review Comment:
Moved `ninja-debug-[sanitizer]` group here after valgrind group.
##########
cpp/CMakePresets.json:
##########
@@ -193,35 +184,54 @@
"features-filesystems",
"features-flight-sql",
"features-gandiva",
- "features-main",
- "features-python-minimal"
+ "features-python"
],
"hidden": true,
"cacheVariables": {
- "ARROW_ORC": "ON",
"PARQUET_REQUIRE_ENCRYPTION": "ON"
}
},
{
"name": "features-maximal",
"inherits": [
- "features-main",
- "features-cuda",
- "features-filesystems",
- "features-flight-sql",
- "features-gandiva",
"features-python-maximal"
],
"hidden": true,
"cacheVariables": {
"ARROW_BUILD_EXAMPLES": "ON",
"ARROW_BUILD_UTILITIES": "ON",
- "ARROW_ORC": "ON",
"ARROW_SKYHOOK": "ON",
"ARROW_TENSORFLOW": "ON",
"PARQUET_BUILD_EXAMPLES": "ON",
- "PARQUET_BUILD_EXECUTABLES": "ON",
- "PARQUET_REQUIRE_ENCRYPTION": "ON"
Review Comment:
Reduce duplication.
##########
cpp/CMakePresets.json:
##########
@@ -371,45 +381,97 @@
"cacheVariables": {}
},
{
- "name": "ninja-debug-valgrind-basic",
+ "name": "ninja-debug-emscripten",
Review Comment:
Adjusting order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
