zanmato1984 commented on code in PR #45210:
URL: https://github.com/apache/arrow/pull/45210#discussion_r1909654742
##########
cpp/CMakePresets.json:
##########
@@ -6,6 +6,30 @@
"patch": 0
},
"configurePresets": [
+ {
+ "name": "_allocator-none",
Review Comment:
Hmm, yes we can. I was trying to add some specialty to `_` presets, that is,
not using it in regular inheritance where there is no conflicting variables.
However I think nothing functional really prevents it from being used in
regular inheritance. I'll try that and update soon.
##########
cpp/CMakePresets.json:
##########
@@ -6,6 +6,30 @@
"patch": 0
},
"configurePresets": [
+ {
+ "name": "_allocator-none",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "OFF",
+ "ARROW_MIMALLOC": "OFF"
+ }
+ },
+ {
+ "name": "_allocator-jemalloc",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "ON",
+ "ARROW_MIMALLOC": "OFF"
Review Comment:
You mean something like this?
```suggestion
```
I think we should always specify one `ON` one `OFF` together (unless we are
100% sure about one value of them being specified earlier) - otherwise there
could be potentially two allocators which is not desired?
##########
cpp/CMakePresets.json:
##########
@@ -6,6 +6,30 @@
"patch": 0
},
"configurePresets": [
+ {
+ "name": "_allocator-none",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "OFF",
+ "ARROW_MIMALLOC": "OFF"
+ }
+ },
+ {
+ "name": "_allocator-jemalloc",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "ON",
+ "ARROW_MIMALLOC": "OFF"
+ }
+ },
+ {
+ "name": "_allocator-mimalloc",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "OFF",
Review Comment:
Answered in my other comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
