pitrou commented on code in PR #45217:
URL: https://github.com/apache/arrow/pull/45217#discussion_r1909439209
##########
cpp/src/arrow/compute/kernels/vector_sort_internal.h:
##########
@@ -238,33 +198,28 @@ NullPartitionResult PartitionNullsOnly(uint64_t*
indices_begin, uint64_t* indice
//
// `offset` is used when this is called on a chunk of a chunked array
template <typename ArrayType, typename Partitioner>
-enable_if_t<!has_null_like_values<typename ArrayType::TypeClass>::value,
- NullPartitionResult>
-PartitionNullLikes(uint64_t* indices_begin, uint64_t* indices_end,
- const ArrayType& values, int64_t offset,
- NullPlacement null_placement) {
- return NullPartitionResult::NoNulls(indices_begin, indices_end,
null_placement);
-}
-
-template <typename ArrayType, typename Partitioner>
-enable_if_t<has_null_like_values<typename ArrayType::TypeClass>::value,
- NullPartitionResult>
-PartitionNullLikes(uint64_t* indices_begin, uint64_t* indices_end,
- const ArrayType& values, int64_t offset,
- NullPlacement null_placement) {
- Partitioner partitioner;
- if (null_placement == NullPlacement::AtStart) {
- auto null_likes_end =
- partitioner(indices_begin, indices_end, [&values, &offset](uint64_t
ind) {
- return std::isnan(values.GetView(ind - offset));
- });
- return NullPartitionResult::NullsAtStart(indices_begin, indices_end,
null_likes_end);
+NullPartitionResult PartitionNullLikes(uint64_t* indices_begin, uint64_t*
indices_end,
+ const ArrayType& values, int64_t offset,
+ NullPlacement null_placement) {
+ if constexpr (has_null_like_values<typename ArrayType::TypeClass>()) {
+ Partitioner partitioner;
+ if (null_placement == NullPlacement::AtStart) {
+ auto null_likes_end =
Review Comment:
Hmm, this change is actually a small unrelated refactor. It does not change
any functionality, it's just moving some of the helper code to more modern
C++17 idioms such as `if constexpr` :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
