zanmato1984 commented on code in PR #45217:
URL: https://github.com/apache/arrow/pull/45217#discussion_r1912955593
##########
cpp/src/arrow/type_traits.h:
##########
@@ -1069,6 +1069,13 @@ constexpr bool is_floating(Type::type type_id) {
return false;
}
+/// \brief Check for a physical floating point type
+///
+/// This predicate matches floating-point types, except half-float.
+constexpr bool is_physical_floating(Type::type type_id) {
Review Comment:
How about we use `switch cases` in this function and change `is_floating` to
call `return is_physical_floating() || type_id == Type::HALF_FLOAT`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
