wgtmac commented on code in PR #45226: URL: https://github.com/apache/arrow/pull/45226#discussion_r1912849123
########## cpp/src/arrow/adapters/orc/adapter_test.cc: ########## @@ -235,7 +235,7 @@ void AssertTableWriteReadEqual(const std::vector<std::shared_ptr<Table>>& input_ write_options.compression = Compression::UNCOMPRESSED; #endif write_options.file_version = adapters::orc::FileVersion(0, 11); - write_options.compression_block_size = 32768; + write_options.compression_block_size = 64 * 1024; Review Comment: See: https://github.com/apache/arrow/actions/runs/12739333012/job/35503268303 ``` [==========] Running 40 tests from 11 test suites. [----------] Global test environment set-up. [----------] 3 tests from TestAdapterRead [ RUN ] TestAdapterRead.ReadIntAndStringFileMultipleStripes unknown file: Failure C++ exception with description "Compression block size must be a multiple of memory block size." thrown in the test body. [ FAILED ] TestAdapterRead.ReadIntAndStringFileMultipleStripes (165 ms) [ RUN ] TestAdapterRead.ReadCharAndVarcharType unknown file: Failure C++ exception with description "Compression block size must be a multiple of memory block size." thrown in the test body. [ FAILED ] TestAdapterRead.ReadCharAndVarcharType (162 ms) [ RUN ] TestAdapterRead.ReadFieldAttributes unknown file: Failure C++ exception with description "Compression block size must be a multiple of memory block size." thrown in the test body. [ FAILED ] TestAdapterRead.ReadFieldAttributes (170 ms) [----------] 3 tests from TestAdapterRead (497 ms total) ``` In short, the default compression block size should be a multiply of 64K: https://github.com/apache/orc/blob/main/c%2B%2B/src/Writer.cc#L377-L380. This is a slight breaking change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
