kou commented on code in PR #45226: URL: https://github.com/apache/arrow/pull/45226#discussion_r1912867830
########## cpp/src/arrow/adapters/orc/adapter_test.cc: ########## @@ -235,7 +235,7 @@ void AssertTableWriteReadEqual(const std::vector<std::shared_ptr<Table>>& input_ write_options.compression = Compression::UNCOMPRESSED; #endif write_options.file_version = adapters::orc::FileVersion(0, 11); - write_options.compression_block_size = 32768; + write_options.compression_block_size = 64 * 1024; Review Comment: OK. This option value is valid with old ORC, right? (Old ORC doesn't have this check.) System ORC may be older than 2.1.0. ########## cpp/src/arrow/adapters/orc/adapter_test.cc: ########## @@ -235,7 +235,7 @@ void AssertTableWriteReadEqual(const std::vector<std::shared_ptr<Table>>& input_ write_options.compression = Compression::UNCOMPRESSED; #endif write_options.file_version = adapters::orc::FileVersion(0, 11); - write_options.compression_block_size = 32768; + write_options.compression_block_size = 64 * 1024; Review Comment: OK. This option value is valid with old ORC, right? (Old ORC doesn't have this check, right?) System ORC may be older than 2.1.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
