svencowart commented on PR #6965: URL: https://github.com/apache/arrow-rs/pull/6965#issuecomment-2591015684
@alamb, we're improving the reader and providing more Avro tests. As I was working on this, I noticed the module signature for arrow's [parquet reader](https://github.com/apache/arrow-rs/blob/main/parquet/src/arrow/arrow_reader/mod.rs) and datafusion's [arrow_array_reader.rs](https://github.com/apache/datafusion/blob/main/datafusion/core/src/datasource/avro_to_arrow/arrow_array_reader.rs) are based on a Builder pattern. To simplify adopting these arrow-avro changes into DataFusion, should we implement the module signature to something similar to what is already in DataFusion today? Or are you looking for something else? Also, do you prefer whether the public signature for the reader should be included in this PR or a PR following this PR that proves the reader changes? I'm happy to contribute the public module signature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
