svencowart commented on PR #6965: URL: https://github.com/apache/arrow-rs/pull/6965#issuecomment-2591108486
> In my opinion, the code in this crate (arrow-rs) should follow the existing patterns in this repository (specifically the parquet arrow reader https://github.com/apache/arrow-rs/blob/main/parquet/src/arrow/arrow_reader/mod.rs that you point to) Thank you, I'll do that. > Given the current release process, we need to be careful with breaking API changes as described in https://github.com/apache/arrow-rs/blob/main/CONTRIBUTING.md#breaking-changes > > Thus in so far that we can avoid causing API churn / require contortions that would be good I 100% agree. Thank you for sharing that link. > > One thing we could do potentially is put all the code behind the experimental feature flag so are free to modify the API even as we release minor incremental versions > > I'm aligned with this approach. What do you think @svencowart ? @jecsand838 Let's wait to decide once we complete a public API for the Avro modules. If it all looks strong, well-designed, and well-tested, I don't see why we would put it behind experimental, but I'll leave that up to @alamb and @tustvold to decide — I am not against it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
