WillAyd commented on code in PR #45259:
URL: https://github.com/apache/arrow/pull/45259#discussion_r1925527236
##########
cpp/src/arrow/compute/api_vector.cc:
##########
@@ -151,6 +152,10 @@ static auto kRankOptionsType =
GetFunctionOptionsType<RankOptions>(
DataMember("sort_keys", &RankOptions::sort_keys),
DataMember("null_placement", &RankOptions::null_placement),
DataMember("tiebreaker", &RankOptions::tiebreaker));
+static auto kRankQuantileOptionsType =
GetFunctionOptionsType<RankQuantileOptions>(
+ DataMember("sort_keys", &RankQuantileOptions::sort_keys),
+ DataMember("null_placement", &RankQuantileOptions::null_placement),
+ DataMember("factor", &RankQuantileOptions::factor));
Review Comment:
Since we do have time maybe its worth removing the factor to simplify? What
is the advantage of including into the QuantileRanker class versus return
something in the range 0..1 and having the user supply the factor if they need?
I figure the advantage to taking the factor out would be to simplify the
implementation and give more room for vectorized multiplication applications
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
