icexelloss commented on code in PR #45259:
URL: https://github.com/apache/arrow/pull/45259#discussion_r1926007389
##########
cpp/src/arrow/compute/api_vector.cc:
##########
@@ -151,6 +152,10 @@ static auto kRankOptionsType =
GetFunctionOptionsType<RankOptions>(
DataMember("sort_keys", &RankOptions::sort_keys),
DataMember("null_placement", &RankOptions::null_placement),
DataMember("tiebreaker", &RankOptions::tiebreaker));
+static auto kRankQuantileOptionsType =
GetFunctionOptionsType<RankQuantileOptions>(
+ DataMember("sort_keys", &RankQuantileOptions::sort_keys),
+ DataMember("null_placement", &RankQuantileOptions::null_placement),
+ DataMember("factor", &RankQuantileOptions::factor));
Review Comment:
I don't see it being too useful - I think most of the cases (0, 1) is enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
