xborder opened a new pull request, #2481: URL: https://github.com/apache/arrow-adbc/pull/2481
* Fixes [#2434](https://github.com/apache/arrow-adbc/issues/2434) * Moved driver-agnostic metadata parsing out of `shared_utils.go` * Each driver can now implement its own logic for handling `XDBC_` fields using fields metadata * Snowflake and BigQuery drivers seem unaffected as they use separate implementations * Relocated `ToXdbcDataType` function to `shared_utils.go` to resolve circular dependency issues * Aligned implementation with documentation by: * Ensuring all documented XDBC_ fields are properly fetched * Removing undocumented fields (`COMMENT`, `CHARACTER_MAXIMUM_LENGTH`, `XDBC_SCALE`, `XDBC_PRECISION`) *`COMMENT`, `CHARACTER_MAXIMUM_LENGTH` seem to be snowflake specific even though it seems snowflake adbc driver has a separate implementation. * Couldn't find any documentation regarding `XDBC_SCALE`, `XDBC_PRECISION` * Restored tests that verify proper metadata field population -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
