zeroshade commented on code in PR #2481:
URL: https://github.com/apache/arrow-adbc/pull/2481#discussion_r1927404870
##########
go/adbc/driver/flightsql/flightsql_connection.go:
##########
@@ -57,10 +57,63 @@ type connectionImpl struct {
supportInfo support
}
+type flightSqlMetadata struct {
+ internal.DefaultXdbcMetadataBuilder
+}
+
+func (md *flightSqlMetadata) SetXdbcScopeCatalog(b *array.StringBuilder) {
+ f := &flightsql.ColumnMetadata{Data: md.Metadata()}
Review Comment:
rather than doing this on every call here, why not have the `SetMetadata`
method create this and make it a member of `flightSqlMetadata` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
