ianmcook commented on a change in pull request #9745:
URL: https://github.com/apache/arrow/pull/9745#discussion_r599969084
##########
File path: r/R/dplyr.R
##########
@@ -631,17 +669,98 @@ abandon_ship <- function(call, .data, msg = NULL) {
eval.parent(call, 2)
}
-arrange.arrow_dplyr_query <- function(.data, ...) {
+arrange.arrow_dplyr_query <- function(.data, ..., .by_group = FALSE) {
+ # TODO: handle .by_group argument
+ if (!isFALSE(.by_group)) {
+ stop(".by_group argument not supported for Arrow objects", call. = FALSE)
+ }
+
+ call <- match.call()
+ exprs <- quos(...)
+
+ if (length(exprs) == 0) {
+ # Nothing to do
+ return(.data)
+ }
+
.data <- arrow_dplyr_query(.data)
+
+ # Restrict the cases we support for now
if (query_on_dataset(.data)) {
not_implemented_for_dataset("arrange()")
}
- # TODO(ARROW-11703) move this to Arrow
- call <- match.call()
- abandon_ship(call, .data)
+ is_grouped <- length(dplyr::group_vars(.data)) > 0
Review comment:
Added support for `.by_group = TRUE` in
7aacacc9f63ac0b74be47c39a7a404c892db557b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
