ianmcook commented on a change in pull request #9745:
URL: https://github.com/apache/arrow/pull/9745#discussion_r600109663
##########
File path: r/R/dplyr.R
##########
@@ -390,6 +414,16 @@ collect.arrow_dplyr_query <- function(x, as_data_frame =
TRUE, ...) {
tab <- RecordBatch$create(!!!cols)
}
}
+ # Arrange rows
+ if (length(x$arrange_vars) > 0) {
+ x$arrange_vars <- get_field_names(x$arrange_vars)
Review comment:
Good catch; you're correct—`get_field_names()` serves no purpose here.
It had a purpose earlier, but then I changed how this all works and forgot to
remove it. It's removed in f8dd5b922706c9a0b54d0f43094253b5d0bf3e25.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
